New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote cronjob_job_creation_skew metric to stable #113008
Promote cronjob_job_creation_skew metric to stable #113008
Conversation
/triage accepted |
/lgtm |
7513d16
to
5e2f3a6
Compare
/lgtm |
@@ -31,7 +31,7 @@ var ( | |||
Subsystem: CronJobControllerSubsystem, | |||
Name: "cronjob_job_creation_skew_duration_seconds", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that we are doing the same mistake in other places, but I think this should just be job_creation_skew_duration_seconds
, given that the metric is already part of the CronJobControllerSubsystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, since this is a metric from the cronjob controller, it is explicit that the jobs it gives information about are from a cronjob so adding this additional prefix is redundant.
This PR may require stable metrics review. Stable metrics are guaranteed to not change. Please review the documentation for the requirements and lifecycle of stable metrics and ensure that your metrics meet these guidelines. |
/test pull-kubernetes-e2e-gce-100-performance |
/assign @dgrisonnet |
5e2f3a6
to
4af97e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind cleanup
/sig apps
What this PR does / why we need it:
This should've been promoted along with the new cronjob controller, as part of kubernetes/enhancements#19
Special notes for your reviewer:
/assign @atiratree
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: