Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert 109706 + 111691 #112807

Merged
merged 3 commits into from Oct 1, 2022
Merged

Revert 109706 + 111691 #112807

merged 3 commits into from Oct 1, 2022

Conversation

alexanderConstantinescu
Copy link
Member

@alexanderConstantinescu alexanderConstantinescu commented Sep 30, 2022 •
edited by liggitt

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

This reverts #109706 and #111691 which caused #112793

A fix PR is up (#112798), but this part of Kube is...well, complicated and does not have a very broad set of E2E tests. So doubts are expressed as to how exhaustive the fix really is, hence why this PR is up.

Which issue(s) this PR fixes:

Fixes #112798

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a 1.25 regression syncing load balancers for ExternalTrafficPolicy=Local incorrectly under certain conditions by reverting https://github.com/kubernetes/kubernetes/pull/109706 and https://github.com/kubernetes/kubernetes/pull/111691 which caused https://github.com/kubernetes/kubernetes/issues/112793.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @thockin
/cc @swetharepakula
/cc @panslava

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

@alexanderConstantinescu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2022
@alexanderConstantinescu
Copy link
Member Author

/sig network
/sig cloud-provider

@alexanderConstantinescu alexanderConstantinescu mentioned this pull request Sep 30, 2022
Closed
@swetharepakula
Copy link
Member

/lgtm

Thanks for making the PR so quickly!

/cc @bowei @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
@panslava
Copy link
Contributor

/lgtm

Thank you for really quick involvement on this!

@liggitt
Copy link
Member

liggitt commented Sep 30, 2022

lgtm (I verified this takes the sync logic of this controller back to 1.24-state)

will defer to @bowei @thockin for approval

@thockin
Copy link
Member

thockin commented Sep 30, 2022

Sorry to lose this from the release, but I concur

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@thockin
Copy link
Member

thockin commented Sep 30, 2022

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team September 30, 2022 19:46
xmudrii
xmudrii approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, thockin, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 1, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit f28838c into kubernetes:release-1.25 Oct 1, 2022
@liggitt liggitt mentioned this pull request Oct 6, 2022
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 26, 2022
Merged
@aojea aojea mentioned this pull request Feb 5, 2023
Merged
@liggitt
Copy link
Member

liggitt commented Sep 9, 2023 •
edited

the commits this is reverting in release-1.25 never got reverted in master / 1.26+ ... can you link to the later commits in master that resolved this issue?

@alexanderConstantinescu
Copy link
Member Author

can you link to the later commits in master that resolved this issue?

This merged on 1.26 during the feature cycle and fixed the bug: #111663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@panslava panslava Awaiting requested review from panslava

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

@bowei bowei Awaiting requested review from bowei

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@swetharepakula swetharepakula

@thockin thockin

@xmudrii xmudrii

@panslava panslava

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alexanderConstantinescu @k8s-ci-robot @swetharepakula @panslava @liggitt @thockin @xmudrii