Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #111772: kubelet: make the image pull time more accurate in event #114271

Merged
merged 2 commits into from Dec 13, 2022
Merged

Automated cherry pick of #111772: kubelet: make the image pull time more accurate in event #114271

merged 2 commits into from Dec 13, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Dec 3, 2022 •
edited

Cherry pick of #111772 on release-1.25.

#111772: kubelet: make the image pull time more accurate in event

For details on the cherry pick process, see the cherry pick requests page.

kubelet: make the image pull time more accurate in event

#111772 (comment)

Can we consider to backport this to the recent few releases, e.g. 1.25, 1.24? I think it's a pretty small isolated change and will help to reduce a lot of confusion.

cc @pacoxu

I've seen quite a few folks being confused with the misleading events regarding image pulls, especially when used with serial image pulls. Often the case is that a small image pull may report a very long image pull time when in reality it was blocked behind a much larger image pull.

@pacoxu
kubelet: make the image pull time more accurate in event
6b8222c 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@pacoxu
image pull event include duration with waiting
b163ce9 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Dec 3, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 3, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 3, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 3, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Dec 4, 2022

/cc @bobbypage @klueska

@pacoxu
Copy link
Member Author

pacoxu commented Dec 5, 2022

/kind bug
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 5, 2022
@aimuz
Copy link
Contributor

aimuz commented Dec 5, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2022
@bobbypage
Copy link
Member

/lgtm

Thanks for backporting this, I think this will reduce confusion. One small nit, perhaps it's worth to add release note.

/assign @mrunalp
for approval

@klueska
Copy link
Contributor

klueska commented Dec 5, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Dec 7, 2022

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team December 7, 2022 03:26
@xmudrii
Copy link
Member

xmudrii commented Dec 7, 2022

We're now past the cherry-pick deadline, so we'll not be able to include this cherry-pick in the December patch releases. We'll make sure to review this PR as soon as the December patch releases are out.

@xmudrii
Copy link
Member

xmudrii commented Dec 12, 2022

From @bobbypage:

One small nit, perhaps it's worth to add release note.

@pacoxu I agree with this -- can you please add a release note for this change?

Also, I only see cherry-picks for 1.25 and 1.24. Should we also include this in 1.23? If it is possible to include it, would you mind creating a cherry-pick for 1.23 as well?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 12, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Dec 12, 2022

Updated.
v1.23 cherry-pick is opened #114430

@puerco
Copy link
Member

puerco commented Dec 13, 2022

Awesome @pacoxu , waiting for the 1.23 approval to merge the whole set. Thank you! 🚀

xmudrii
xmudrii approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, pacoxu, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Dec 13, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 434d081 into kubernetes:release-1.25 Dec 13, 2022
SIG Node PR Triage automation moved this from Triage to Done Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@feiskyer feiskyer Awaiting requested review from feiskyer

@bobbypage bobbypage Awaiting requested review from bobbypage

@klueska klueska Awaiting requested review from klueska

Assignees

@mrunalp mrunalp

@bobbypage bobbypage

@aimuz aimuz

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pacoxu @k8s-ci-robot @aimuz @bobbypage @klueska @xmudrii @puerco @mrunalp