New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not raise an error proposing to use '--overwrite' when annotating with the same value #109505
Conversation
Hi @zigarn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
Sounds reasonable to me. |
/assign @deads2k |
Annotations: map[string]string{"a": "b"}, | ||
}, | ||
}, | ||
annotations: map[string]string{"a": "c"}, | ||
expectErr: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be willing to make the same improvement to these tests that you made in the labels PR, so they prove we're getting the specific error we expect? #105936 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. It's done.
/auto-cc |
/auto-cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, zigarn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Equivalent of PR #105936 for annotations.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, when trying to set a label with the same value as current one,
kubectl
advise to use the--overwrite
option:But then, overwriting for the same value is a bit weird.
This PR propose to detect this situation and do nothing:
Which issue(s) this PR fixes:
No existing issue.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: