CloudProvider: service update event should be triggered when appProtocol in port is changed #112785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/assign @thockin |
MartinForReal
force-pushed
the
master
branch
from
4db5a61
to
6b2a395
Compare
|
/assign @thockin |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
andrewsykim
reviewed
Oct 3, 2022
staging/src/k8s.io/cloud-provider/controllers/service/controller.go
Outdated
Show resolved
Hide resolved
|
/retitle CloudProvider: service update event should be triggered when appProtocol in port is changed |
k8s-ci-robot
changed the title
andrewsykim
reviewed
Oct 11, 2022
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
Outdated
Show resolved
Hide resolved
…changed. Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
|
/retest-required |
/test pull-kubernetes-conformance-kind-ga-only-parallel |
|
Thanks! I can't approve, so will leave that for @andrewsykim. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Oct 13, 2022
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 15, 2022
…f-#112785-upstream-release-1.23 Automated cherry pick of #112785: service update event should be triggered when appProtocol in
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 15, 2022
…f-#112785-upstream-release-1.25 Automated cherry pick of #112785: service update event should be triggered when appProtocol in
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 15, 2022
…f-#112785-upstream-release-1.24 Automated cherry pick of #112785: service update event should be triggered when appProtocol in
|
My suggested changelog entry: Fixed a bug where a change in the `appProtocol` for a Service did not trigger a load balancer update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
service update event should be triggered when appProtocol in port is changed
Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#2434
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: