New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudProvider: service update event should be triggered when appProtocol in port is changed #112785
Conversation
/assign @thockin |
4db5a61
to
6b2a395
Compare
/assign @thockin |
/triage accepted |
staging/src/k8s.io/cloud-provider/controllers/service/controller.go
Outdated
Show resolved
Hide resolved
/retitle CloudProvider: service update event should be triggered when appProtocol in port is changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
Outdated
Show resolved
Hide resolved
…changed. Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
/retest-required |
/test pull-kubernetes-conformance-kind-ga-only-parallel |
Thanks! I can't approve, so will leave that for @andrewsykim. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…f-#112785-upstream-release-1.23 Automated cherry pick of #112785: service update event should be triggered when appProtocol in
…f-#112785-upstream-release-1.25 Automated cherry pick of #112785: service update event should be triggered when appProtocol in
…f-#112785-upstream-release-1.24 Automated cherry pick of #112785: service update event should be triggered when appProtocol in
My suggested changelog entry: Fixed a bug where a change in the `appProtocol` for a Service did not trigger a load balancer update. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
service update event should be triggered when appProtocol in port is changed
Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#2434
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: