New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: allow RSA and ECDSA format keys in preflight check #112508
Conversation
@SataQiu: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
seems straightforward, thanks @SataQiu
…508-upstream-release-1.24 Automated cherry pick of #112508: kubeadm: allow RSA and ECDSA format keys in preflight check
…508-upstream-release-1.25 Automated cherry pick of #112508: kubeadm: allow RSA and ECDSA format keys in preflight check
…508-upstream-release-1.23 Automated cherry pick of #112508: kubeadm: allow RSA and ECDSA format keys in preflight check
…508-upstream-release-1.22 Automated cherry pick of #112508: kubeadm: allow RSA and ECDSA format keys in preflight check
I would changelog this as: “kubeadm: allow both RSA and ECDSA format keys in preflight check” or some other wording that doesn't imply that RSA key support is brand new. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
kubeadm: allow RSA and ECDSA format keys in preflight check
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#2756
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: