Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: allow RSA and ECDSA format keys in preflight check #112508

Merged
merged 1 commit into from Sep 16, 2022
Merged

kubeadm: allow RSA and ECDSA format keys in preflight check #112508

merged 1 commit into from Sep 16, 2022

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 16, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

kubeadm: allow RSA and ECDSA format keys in preflight check

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#2756

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: allow RSA and ECDSA format keys in preflight check

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 16, 2022
@k8s-ci-robot
Copy link
Contributor

@SataQiu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2022
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 16, 2022
neolit123
neolit123 reviewed Sep 16, 2022
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
seems straightforward, thanks @SataQiu

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit cccfc09 into kubernetes:master Sep 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 16, 2022
This was referenced Sep 17, 2022
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2022
@k8s-ci-robot
Merge pull request #112535 from SataQiu/automated-cherry-pick-of-#112…
44b5e29 
…508-upstream-release-1.24

Automated cherry pick of #112508: kubeadm: allow RSA and ECDSA format keys in preflight check
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2022
@k8s-ci-robot
Merge pull request #112534 from SataQiu/automated-cherry-pick-of-#112…
132e420 
…508-upstream-release-1.25

Automated cherry pick of #112508: kubeadm: allow RSA and ECDSA format keys in preflight check
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2022
@k8s-ci-robot
Merge pull request #112536 from SataQiu/automated-cherry-pick-of-#112…
8d41816 
…508-upstream-release-1.23

Automated cherry pick of #112508: kubeadm: allow RSA and ECDSA format keys in preflight check
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2022
@k8s-ci-robot
Merge pull request #112537 from SataQiu/automated-cherry-pick-of-#112…
96e269c 
…508-upstream-release-1.22

Automated cherry pick of #112508: kubeadm: allow RSA and ECDSA format keys in preflight check
@sftim
Copy link
Contributor

sftim commented Sep 20, 2022

I would changelog this as:

“kubeadm: allow both RSA and ECDSA format keys in preflight check”

or some other wording that doesn't imply that RSA key support is brand new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@RA489 RA489 Awaiting requested review from RA489

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

"/etc/kubernetes/pki/sa.key isn't in RSA format" error when using ECDSA certs
4 participants
@SataQiu @k8s-ci-robot @sftim @neolit123