Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: silence flag output on errors #110728

Merged
merged 2 commits into from Jun 27, 2022
Merged

kubelet: silence flag output on errors #110728

merged 2 commits into from Jun 27, 2022

Conversation

howardjohn
Copy link
Contributor

@howardjohn howardjohn commented Jun 22, 2022 •
edited by k8s-ci-robot

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently, the --help text is output on kubelet errors. Currently on
my machine this is 280 lines. Typically kubelet is run by systemd or
similar, starting it a loop. This means when an issue is encountered, we
are spammed by 100s of logs per second, masking the real error.

With this PR, the list of all flags is silenced. Users can still access
them by kubelet --help as normal. This same SilenceUsage is already
set in the api-server command.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubelet: silence flag output on errors

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@howardjohn
kubelet: silence flag output on errors
b45325a 
Currently, the `--help` text is output on kubelet errors. Currently on
my machine this is 280 lines. Typically kubelet is run by systemd or
similar, starting it a loop. This means when an issue is encountered, we
are spammed by 100s of logs per second, masking the real error.

With this PR, the list of all flags is silenced. Users can still access
them by `kubelet --help` as normal. This same `SilenceUsage` is already
set in the api-server command.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @howardjohn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 22, 2022
@pacoxu
Copy link
Member

pacoxu commented Jun 24, 2022

/ok-to-test
/kind important-longterm

@k8s-ci-robot
Copy link
Contributor

@pacoxu: The label(s) kind/important-longterm cannot be applied, because the repository doesn't have them.

In response to this:

/ok-to-test
/kind important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2022
@pacoxu
Copy link
Member

pacoxu commented Jun 24, 2022

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2022
@pacoxu pacoxu added this to Needs Approver in SIG Node PR Triage Jun 24, 2022
@pacoxu pacoxu moved this from Needs Approver to Needs Reviewer in SIG Node PR Triage Jun 24, 2022
@pacoxu
Copy link
Member

pacoxu commented Jun 24, 2022 •
edited

/triage accepted
The go formant failure should be fixed.

[root@paco ~]# ./kubelet version
Error: unknown command version
[root@paco ~]# ./kubelet -version
Error: failed to parse kubelet flag: invalid argument "ersion" for "-v, --v" flag: strconv.ParseUint: parsing "ersion": invalid syntax

With this fix, kubelet version will be extremely clear.
/approve
will lgtm once the CI is green

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 24, 2022
pacoxu
pacoxu reviewed Jun 24, 2022
View reviewed changes
cmd/kubelet/app/server.go Outdated Show resolved Hide resolved
@howardjohn @pacoxu
Update cmd/kubelet/app/server.go
4ca53d1 
Co-authored-by: Paco Xu <paco.xu@daocloud.io>
@sftim
Copy link
Contributor

sftim commented Jun 25, 2022

This PR does introduce a user-facing change, right? I'd expect to see a changelog entry.

@pacoxu
Copy link
Member

pacoxu commented Jun 27, 2022

/release-note-edit

kubelet: silence flag output on errors

/label tide/merge-method-squash
/lgtm
/cc @mrunalp

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@pacoxu pacoxu moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit c6b0652 into kubernetes:master Jun 27, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@mrunalp mrunalp mrunalp approved these changes

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@howardjohn @k8s-ci-robot @pacoxu @sftim @mrunalp