New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: silence flag output on errors #110728
kubelet: silence flag output on errors #110728
Conversation
Currently, the `--help` text is output on kubelet errors. Currently on my machine this is 280 lines. Typically kubelet is run by systemd or similar, starting it a loop. This means when an issue is encountered, we are spammed by 100s of logs per second, masking the real error. With this PR, the list of all flags is silenced. Users can still access them by `kubelet --help` as normal. This same `SilenceUsage` is already set in the api-server command.
Hi @howardjohn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@pacoxu: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-longterm |
/triage accepted
With this fix, |
Co-authored-by: Paco Xu <paco.xu@daocloud.io>
This PR does introduce a user-facing change, right? I'd expect to see a changelog entry. |
/release-note-edit
/label tide/merge-method-squash |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, mrunalp, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Currently, the
--help
text is output on kubelet errors. Currently onmy machine this is 280 lines. Typically kubelet is run by systemd or
similar, starting it a loop. This means when an issue is encountered, we
are spammed by 100s of logs per second, masking the real error.
With this PR, the list of all flags is silenced. Users can still access
them by
kubelet --help
as normal. This sameSilenceUsage
is alreadyset in the api-server command.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: