New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter out terminated containers in cadvisor_stats_provider #110950
filter out terminated containers in cadvisor_stats_provider #110950
Conversation
8a9e9fd
to
86f0384
Compare
/cc @MrHohn @haircommander @249043822 |
/retest |
1 similar comment
/retest |
/test pull-kubernetes-e2e-gce-100-performance |
/test pull-kubernetes-e2e-kind |
/retest |
/test pull-kubernetes-e2e-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
this approach makes sense to me. I have one comment, and the test failures seem legit so something else probably needs changing, but overall LGTM |
ee8b19a
to
44801e3
Compare
44801e3
to
cafc5d1
Compare
/triage accepted |
This looks like it should address the issue that came up. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, yangjunmyfm192085 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…10950-upstream-release-1.24 [1.24] Automated cherry pick of #110950: filter out terminated containers in cadvisor_stats_provider
…10950-upstream-release-1.23 [1.23] Automated cherry pick of #110950: filter out terminated containers in cadvisor_stats_provider
What type of PR is this?
/kind bug
What this PR does / why we need it:
if the container has only one instance, we should still check whether it was terminated(as cpu memory and network(special case) 0), since init-container exits and would not be restarted, it may have only one exited instance
Which issue(s) this PR fixes:
Fixes #103368
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: