Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote DelegateFSGroupToCSIDriver feature to GA #113225

Merged
merged 2 commits into from Nov 4, 2022
Merged

Promote DelegateFSGroupToCSIDriver feature to GA #113225

merged 2 commits into from Nov 4, 2022

Conversation

bertinatto
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR promotes the DelegateFSGroupToCSIDriver feature to GA.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Not ready for review, this depends on container-storage-interface/spec#509.

Does this PR introduce a user-facing change?

DelegateFSGroupToCSIDriver feature is GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 20, 2022
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 20, 2022
@k8s-ci-robot
Copy link
Contributor

@bertinatto: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 20, 2022
@gnufied gnufied mentioned this pull request Oct 20, 2022
Merged
@bertinatto bertinatto force-pushed the delete-fsgroup-to-csi-driver-ga branch from 9afd177 to a808684 Compare October 21, 2022 13:53
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Oct 21, 2022
@bertinatto bertinatto force-pushed the delete-fsgroup-to-csi-driver-ga branch from a808684 to 783ab75 Compare October 21, 2022 18:01
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/apiserver area/cloudprovider area/code-generation area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2022
@bertinatto bertinatto force-pushed the delete-fsgroup-to-csi-driver-ga branch from 783ab75 to 536d415 Compare October 24, 2022 19:14
@jsafrane
Copy link
Member

jsafrane commented Nov 3, 2022

Deps were reverted in the latest csi-spec 1.7.0-rc3 tag and now it looks much better.

@liggitt
Copy link
Member

liggitt commented Nov 3, 2022

thanks, dep update lgtm now. ping when the actual release tag is cut and this is updated to that

@bertinatto bertinatto force-pushed the delete-fsgroup-to-csi-driver-ga branch from 0e06a5d to bd5b18a Compare November 3, 2022 21:10
@jsafrane
Copy link
Member

jsafrane commented Nov 4, 2022

/test pull-kubernetes-e2e-gce-storage-snapshot

@jsafrane
Copy link
Member

jsafrane commented Nov 4, 2022

@liggitt the PR was updated to final CSI tag 1.7.0, PTAL.

@kubernetes kubernetes deleted a comment from k8s-ci-robot Nov 4, 2022
@bertinatto
Promote DelegateFSGroupToCSIDriver feature to GA
b19172c
@bertinatto
dependencies: bump CSI to v1.17.0
c352951 
This is required in order to promote DelegateFSGroupToCSIDriver
to GA.
@bertinatto bertinatto force-pushed the delete-fsgroup-to-csi-driver-ga branch from bd5b18a to c352951 Compare November 4, 2022 10:28
@bertinatto
Copy link
Member Author

/retitle Promote DelegateFSGroupToCSIDriver feature to GA

@k8s-ci-robot k8s-ci-robot changed the title WIP: Promote DelegateFSGroupToCSIDriver feature to GA Promote DelegateFSGroupToCSIDriver feature to GA Nov 4, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2022
@bertinatto
Copy link
Member Author

/assign @gnufied @jsafrane
PTAL

@jsafrane
Copy link
Member

jsafrane commented Nov 4, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2022
@gnufied
Copy link
Member

gnufied commented Nov 4, 2022

/assign @liggitt @thockin

@liggitt
Copy link
Member

liggitt commented Nov 4, 2022

Dependency update lgtm

The KEP references "Tested via e2e and manually using azurefile CSI driver." as a precondition to GA. Is there a link to the e2e exercising this?

@gnufied
Copy link
Member

gnufied commented Nov 4, 2022

Yeah - https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/2317-fsgroup-on-mount/README.md#e2e-tests

@liggitt
Copy link
Member

liggitt commented Nov 4, 2022

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@k8s-ci-robot
Copy link
Contributor

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-capz-azure-disk a808684633f5f37216dd81964d4e2b5072e01271 link false /test pull-kubernetes-e2e-capz-azure-disk
pull-kubernetes-e2e-capz-azure-file a808684633f5f37216dd81964d4e2b5072e01271 link false /test pull-kubernetes-e2e-capz-azure-file
pull-kubernetes-e2e-capz-conformance a808684633f5f37216dd81964d4e2b5072e01271 link false /test pull-kubernetes-e2e-capz-conformance
pull-kubernetes-e2e-capz-azure-file-vmss a808684633f5f37216dd81964d4e2b5072e01271 link false /test pull-kubernetes-e2e-capz-azure-file-vmss
pull-kubernetes-e2e-capz-azure-disk-vmss a808684633f5f37216dd81964d4e2b5072e01271 link false /test pull-kubernetes-e2e-capz-azure-disk-vmss
pull-kubernetes-e2e-capz-windows-containerd e5f88100c91a96bc44af34f627c8d03ec505856e link false /test pull-kubernetes-e2e-capz-windows-containerd
pull-kubernetes-unit c352951 link unknown /test pull-kubernetes-unit
pull-kubernetes-e2e-kind c352951 link unknown /test pull-kubernetes-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit d3601a0 into kubernetes:master Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 4, 2022
@bertinatto bertinatto mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@humblec humblec Awaiting requested review from humblec

@thockin thockin Awaiting requested review from thockin

Assignees

@gnufied gnufied

@liggitt liggitt

@jsafrane jsafrane

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bertinatto @k8s-ci-robot @liggitt @dims @leilajal @jsafrane @gnufied @thockin