Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade Azure/go-autorest/autorest to v0.11.27 #110371

Merged
merged 1 commit into from Jun 10, 2022
Merged

upgrade Azure/go-autorest/autorest to v0.11.27 #110371

merged 1 commit into from Jun 10, 2022

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jun 3, 2022 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

upgrade Azure/go-autorest/autorest to v0.11.27
This PR has fix: Azure/go-autorest#669, also increases the timeout value from 0.5s to 2s which fixes the slow IMDS response issue in some cases.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/kind bug
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted

Does this PR introduce a user-facing change?

upgrade Azure/go-autorest/autorest to v0.11.27

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

upgrade Azure/go-autorest/autorest to v0.11.27

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from cheftako, lavalamp and a team June 3, 2022 09:24
@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/dependency Issues or PRs related to dependency changes labels Jun 3, 2022
@dims
Copy link
Member

dims commented Jun 3, 2022

/approve
/lgtm

/assign @thockin @smarterclayton

(need root OWNERS approval)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 3, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 4, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 4, 2022
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-kind-ipv6

@andyzhangx
Copy link
Member Author

/retest

@dims
Copy link
Member

dims commented Jun 9, 2022

/approve
/lgtm
/assign @thockin @smarterclayton

(for root owner approval)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
thockin
thockin reviewed Jun 10, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor/github.com/Azure/go-autorest/autorest/adal/README.md says "This module will go out of support by March 31, 2023. For authenticating with Azure AD, use module azidentity instead"

What's the plan there?

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 59644ff into kubernetes:master Jun 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@andyzhangx
Copy link
Member Author

vendor/github.com/Azure/go-autorest/autorest/adal/README.md says "This module will go out of support by March 31, 2023. For authenticating with Azure AD, use module azidentity instead"

What's the plan there?

/approve

Hi @thockin, this is related to Credential provider extraction plan, once we use the standalone Credential provider out of k/k, we don't need this lib anymore. And btw, we don't upgrade this lib regularly unless we found some bugs, and this PR is for fixing one timeout setting issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@cheftako cheftako Awaiting requested review from cheftako

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dims dims

@smarterclayton smarterclayton

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/dependency Issues or PRs related to dependency changes area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andyzhangx @dims @k8s-ci-robot @thockin @smarterclayton