New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSIMigration feature gate to GA #110410
CSIMigration feature gate to GA #110410
Conversation
@Jiawei0227: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
Can you also add in the release note that the feature gate will be removed in 1.27? /hold /lgtm |
/label api-review |
Gentle ping for API review.
Done. Can we unhold this? |
@@ -817,7 +817,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS | |||
|
|||
CSIInlineVolume: {Default: true, PreRelease: featuregate.Beta}, | |||
|
|||
CSIMigration: {Default: true, PreRelease: featuregate.Beta}, | |||
CSIMigration: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://grep.app/search?q=CSIMigration%3Dfalse still sets this to false in kubernetes repos... should that be addressed before merging this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. With #109541, all intree gcepd tests are disabled by default, so removing the flag from thest testconfig should be fine.
/approve API mechanics of the PR look good, just had the one question about the test-infra configs before lifting the hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Jiawei0227, liggitt, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR to remove the flag in test-infra: kubernetes/test-infra#26647 |
thanks... digging into your PR, I think the only references were from release branch jobs on 1.21 and 1.22, so leaving those in place might actually be ok / necessary |
Yeah, I took another look and it seems those two are targetting 1.21 and 1.22 release which should be good. I closed that PR. |
/hold cancel |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR moves the CSIMigration feature gate to GA. Lock the feature gate so that it cannot be turned off.
Which issue(s) this PR fixes:
Related to kubernetes/enhancements#625
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig storage
/cc @msau42