Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSIMigration feature gate to GA #110410

Merged
merged 1 commit into from Jun 22, 2022
Merged

Conversation

Jiawei0227
Copy link
Contributor

@Jiawei0227 Jiawei0227 commented Jun 6, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR moves the CSIMigration feature gate to GA. Lock the feature gate so that it cannot be turned off.

Which issue(s) this PR fixes:

Related to kubernetes/enhancements#625

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Feature gate `CSIMigration` is locked to enabled. CSIMigration is GA now. The feature gate will be removed in 1.27

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig storage
/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 June 6, 2022 22:51
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

@Jiawei0227: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 6, 2022
@dims
Copy link
Member

dims commented Jun 7, 2022

/approve

@msau42
Copy link
Member

msau42 commented Jun 7, 2022

Can you also add in the release note that the feature gate will be removed in 1.27?

/hold
to wait for the KEP milestones update

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@msau42
Copy link
Member

msau42 commented Jun 7, 2022

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Jun 7, 2022
@enj enj added this to Needs Triage in SIG Auth Old Jun 13, 2022
@Jiawei0227
Copy link
Contributor Author

Gentle ping for API review.

Can you also add in the release note that the feature gate will be removed in 1.27?

Done. Can we unhold this?

@liggitt liggitt self-assigned this Jun 16, 2022
@liggitt liggitt added this to In progress in API Reviews Jun 16, 2022
@@ -817,7 +817,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

CSIInlineVolume: {Default: true, PreRelease: featuregate.Beta},

CSIMigration: {Default: true, PreRelease: featuregate.Beta},
CSIMigration: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27
Copy link
Member

@liggitt liggitt Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://grep.app/search?q=CSIMigration%3Dfalse still sets this to false in kubernetes repos... should that be addressed before merging this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. With #109541, all intree gcepd tests are disabled by default, so removing the flag from thest testconfig should be fine.

@liggitt
Copy link
Member

liggitt commented Jun 16, 2022

/approve

API mechanics of the PR look good, just had the one question about the test-infra configs before lifting the hold

@liggitt liggitt moved this from In progress to API review completed, 1.25 in API Reviews Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Jiawei0227, liggitt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@Jiawei0227
Copy link
Contributor Author

PR to remove the flag in test-infra: kubernetes/test-infra#26647

@liggitt
Copy link
Member

liggitt commented Jun 21, 2022

PR to remove the flag in test-infra: kubernetes/test-infra#26647

thanks... digging into your PR, I think the only references were from release branch jobs on 1.21 and 1.22, so leaving those in place might actually be ok / necessary

@Jiawei0227
Copy link
Contributor Author

PR to remove the flag in test-infra: kubernetes/test-infra#26647

thanks... digging into your PR, I think the only references were from release branch jobs on 1.21 and 1.22, so leaving those in place might actually be ok / necessary

Yeah, I took another look and it seems those two are targetting 1.21 and 1.22 release which should be good. I closed that PR.

@msau42
Copy link
Member

msau42 commented Jun 22, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2022
@Jiawei0227
Copy link
Contributor Author

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: API review completed, 1.25
Archived in project
SIG Auth Old
Closed / Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants