Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature gate CelValidatingAdmission #112792

Merged
merged 2 commits into from Oct 5, 2022
Merged

Add feature gate CelValidatingAdmission #112792

merged 2 commits into from Oct 5, 2022

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Sep 29, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add feature gate CelValidatingAdmissionExtensibility based on kep: http://kep.k8s.io/3488

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added a new feature gate `CelValidatingAdmissionExtensibility` to enable expression validation for Admission Control.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: http://kep.k8s.io/3488

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 29, 2022
@cici37
Copy link
Contributor Author

cici37 commented Sep 29, 2022

/priority soon

@k8s-ci-robot
Copy link
Contributor

@cici37: The label(s) priority/soon cannot be applied, because the repository doesn't have them.

In response to this:

/priority soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cici37
Copy link
Contributor Author

cici37 commented Sep 29, 2022

/priority important-soon
cc @jpbetz

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 29, 2022
@alexzielenski alexzielenski mentioned this pull request Oct 4, 2022
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 4, 2022
@fedebongio
Copy link
Contributor

/triage accepted

andrewsykim
andrewsykim reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

(approving changes based on KEP, deferring lgtm to @jpbetz)

staging/src/k8s.io/apiserver/pkg/features/kube_features.go Outdated
// alpha: v1.26
//
// Enables expression validation in Admission Control
CelValidatingAdmissionExtensibility featuregate.Feature = "CelValidatingAdmissionExtensibility"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on naming: I feel like the Extensibility is maybe redundant in the feature gate name, maybe just CELValidatingAdmission or CELAdmission might be more concise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should Cel be capitlized to CEL, seems like we capitalize abbreviations in other features gates (e.g. APIPriorityAndFairness)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! CELValidatingAdmission looks good to me(we might have CELDefaultingAdmission or converting in the future :) ). Will update if no objection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CELValidatingAdmission sounds good to me, the pros of just CELAdmission is that you leave flexibility to reuse that same feature gate for defaulting/converting admission if it happens to fall under the same KEP (but may be we want them distinct anyways)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with either. Slight preference for CELValidatingAdmission just because I'm 99% sure mutation support is quite a ways off.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, cici37

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@jpbetz
Copy link
Contributor

jpbetz commented Oct 5, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@cici37
Copy link
Contributor Author

cici37 commented Oct 5, 2022

/unhold
Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@cici37
Copy link
Contributor Author

cici37 commented Oct 5, 2022

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@cici37 cici37 changed the title Add feature gate CelValidatingAdmissionExtensibility Add feature gate CelValidatingAdmission Oct 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit b4eec3c into kubernetes:master Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 5, 2022
@cici37 cici37 mentioned this pull request Oct 6, 2022
Merged
@cici37 cici37 mentioned this pull request Oct 28, 2022
Closed
9 tasks
@jpbetz jpbetz mentioned this pull request Nov 2, 2022
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@enj enj Awaiting requested review from enj

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cici37 @k8s-ci-robot @fedebongio @jpbetz @andrewsykim