Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #111772: kubelet: make the image pull time more accurate in event #114430

Merged
merged 2 commits into from Dec 13, 2022
Merged

Automated cherry pick of #111772: kubelet: make the image pull time more accurate in event #114430

merged 2 commits into from Dec 13, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Dec 12, 2022 •
edited

Cherry pick of #111772 on release-1.23.

#111772: kubelet: make the image pull time more accurate in event

For details on the cherry pick process, see the cherry pick requests page.

kubelet: make the image pull time more accurate in event

@pacoxu
kubelet: make the image pull time more accurate in event
9795392 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 12, 2022
@pacoxu pacoxu mentioned this pull request Dec 12, 2022
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 12, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Dec 12, 2022

/cc @bobbypage @klueska xmudrii

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 12, 2022
@pacoxu pacoxu force-pushed the automated-cherry-pick-of-#111772-upstream-release-1.23 branch from e4cd003 to 35d0a5d Compare December 12, 2022 16:45
@pacoxu
image pull event include duration with waiting
981b158 
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@pacoxu pacoxu force-pushed the automated-cherry-pick-of-#111772-upstream-release-1.23 branch from 35d0a5d to 981b158 Compare December 12, 2022 16:47
@pacoxu
Copy link
Member Author

pacoxu commented Dec 13, 2022

/assign @klueska @mrunalp

@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@klueska
Copy link
Contributor

klueska commented Dec 13, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
xmudrii
xmudrii approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, pacoxu, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented Dec 13, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1ae2a39 into kubernetes:release-1.23 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@bobbypage bobbypage Awaiting requested review from bobbypage

@klueska klueska Awaiting requested review from klueska

Assignees

@mrunalp mrunalp

@klueska klueska

@bobbypage bobbypage

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacoxu @k8s-ci-robot @bobbypage @klueska @xmudrii @mrunalp