New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calculating error when adding nominated pods in podTopologySpread #112507
Fix calculating error when adding nominated pods in podTopologySpread #112507
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ahg-g |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…2507-upstream-release-1.25 Automated cherry pick of #112507: Fix calculating error when adding nominated pods in
Signed-off-by: kerthcet kerthcet@gmail.com
What type of PR is this?
/kind bug
/sig scheduling
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Similar to
kubernetes/pkg/scheduler/framework/plugins/podtopologyspread/filtering.go
Lines 273 to 306 in 02ac8ac
When calculating
TpPairToMatchNum
, we'll applymatchNodeInclusionPolicies
with to-schedule pod in L297.So in
updateWithPod
, we should follow this rule.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: