New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote CSIMigrationvSphere to GA #113336
Promote CSIMigrationvSphere to GA #113336
Conversation
@divyenpatel: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
25f5ba2
to
5a3f220
Compare
cc @msau42 who had some concerns about Windows support. |
@divyenpatel @xing-yang Can you add a comment here about Windows support status? I know we have talked about it offline but it would be good to get some clarity here, before we decide to make vSphere CSI migration GA. |
We are working on moving CSI Windows support to GA in the next vSphere CSI Driver release.
|
Chatted with @msau42. She is fine with the plan to move CSI Windows support to GA in vSphere CSI driver next release. |
Addressed concerns from @jsafrane in this thread: |
/hold |
/hold cancel |
pkg/features/kube_features.go
Outdated
@@ -845,7 +845,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS | |||
|
|||
CSIMigrationRBD: {Default: false, PreRelease: featuregate.Alpha}, // Off by default (requires RBD CSI driver) | |||
|
|||
CSIMigrationvSphere: {Default: true, PreRelease: featuregate.Beta}, | |||
CSIMigrationvSphere: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // GA in 1.26 (requires vSphere CSI Driver) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be only comment // remove in 1.28
, so we know when to remove the flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
5a3f220
to
b849c59
Compare
/approve @jingxu97, @msau42 last chance, I will LGTM on Monday my time. (@xing-yang, feel free to lgmt if I forget) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Another potential concerns that we have heard from some of the users is XFS and Raw block support. I filed - kubernetes-sigs/vsphere-csi-driver#2097 to track those issues. Do we have a risk of breaking users if we can't sort these out in time? XFS and Raw block seems like something many customers are using right now and aren't esoteric features as such.... |
What type of PR is this?
/kind feature
/sig storage
What this PR does / why we need it:
CSIMigrationvSphere has been beta since 1.19, on by default since 1.25, this takes it to GA for 1.26.
kubernetes/enhancements#1491
Special notes for your reviewer:
Testing Result
Executed storage tests and they all passed.
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/in_tree.go#L1409
Test Logs
vSphere in tree driver does not support read-only raw block volume so the failure of the following test is expected
[sig-storage] In-tree Volumes [Driver: vsphere] [Testpattern: Dynamic PV (block volmode)] multiVolume [Slow] should concurrently access the single read-only volume from pods on the same node
All other tests have passed.
Logs are here for both topology aware and non topology aware setups - https://gist.github.com/sashrith/6ec82e6d40c566ee0a70f7365d0986b0
cc: @sashrith @xing-yang
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: