New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug that kubectl convert does not pick the right api version #112700
Conversation
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed ensures the extensions API is considered the last when decoding and reading the default option, you can still explicitly request it with --output-version=extensions/v1beta1
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SataQiu, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/triage accepted |
Hope this is OK: /release-note-edit
|
@sftim: /release-note-edit must be used with a release note block. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-edit
|
@sftim: /release-note-edit must be used with a release note block. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OK, not sure about the command but that's the change I recommend. |
Thanks for the PR... one thing to note is that relying on import order is fragile… this preferred order should be set explicitly (and a unit test added to cover this scenario so it doesn't regress) |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the bug that
kubectl convert
does not pick the right api versionWhich issue(s) this PR fixes:
Fixes kubernetes/kubectl#1298
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: