New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: improve tips of incorrect input of kubedm subcommand #111277
kubeadm: improve tips of incorrect input of kubedm subcommand #111277
Conversation
/cc @neolit123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens with kubeadm {init|join|upgrade node} phase
i guess they are unaffected by this change?
we definitely need to ensure this does not introduce behavior changes on the cli other than printing the help screen. |
I just modified the command to call the
|
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/release-note-none
if this change makes it in it should have a release note. /release-note-edit
|
f4d7de1
to
7bd1d90
Compare
/triage accepted |
The code is frozen for v1.25 now, and this PR needs to be rebased and waited. |
7bd1d90
to
ff2071b
Compare
Thanks, fixed. |
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SataQiu
please double check and approve if you think this is good to go.
ff2071b
to
5086b88
Compare
Signed-off-by: chymy <chang.min1@zte.com.cn>
5086b88
to
749256e
Compare
Thanks for your review @neolit123 . fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
let's watch if we somehow break user expectation.
thanks for the pr.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chymy, neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Now kubeadm all commands behave the same way. For beginners, there should be more friendly tips for some sub commands,
Refer to this kubernetes/kubeadm#2728 for details
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#2728
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: