New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iSCSI over ipv6 #110688
Fix iSCSI over ipv6 #110688
Conversation
Addresses in the Kubernetes API objects (PV, Pod) have `[]` around IPv6 addresses, while addresses in /dev/ and /sys/ have addresses without them. Add/remove `[]` as needed.
/triage accepted |
/retest |
Thanks @jsafrane , lgtm . [adding this info here for some reference] : more details https://kubernetes.slack.com/archives/C09QZFCE5/p1659444283160249 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bswartz, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug
What this PR does / why we need it:
Addresses in the Kubernetes API objects (PV, Pod) have
[]
around IPv6 addresses, while addresses in/dev/
and/sys/
don't have them.Add/remove
[]
as needed.Which issue(s) this PR fixes:
Fixes #110687
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
cc @bswartz @rootfs for iSCSI knowledge. I tested it on Fedora and RHEL with a single PV, but I am not an iSCSI expert.