New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PodSecurity: promote config and feature gate to GA #110459
PodSecurity: promote config and feature gate to GA #110459
Conversation
/triage accepted |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
b3b09ee
to
bdfe935
Compare
da9d9a1
to
53461d5
Compare
@liggitt @tallclair I have modified this PR. Could you review it again? Thanks. |
staging/src/k8s.io/pod-security-admission/admission/api/v1beta1/defaults_test.go
Outdated
Show resolved
Hide resolved
a couple final changes, squash to a single commit, then lgtm |
Signed-off-by: wangyysde <net_use@bzhy.com>
53461d5
to
ab66a38
Compare
@liggitt @tallclair I have modified this PR. Could you review it again? Thanks. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, wangyysde The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Can I suggest a changelog tweak? -The PodSecurity admission plugin has graduated to ga and is locked to enable. The admission configuration version has been promoted to pod-security.admission.config.k8s.io/v1. See https://kubernetes.io/docs/concepts/security/pod-security-admission/ for usage guidelines.
+The PodSecurity admission plugin has graduated to GA and is enabled by default. The admission configuration version has been promoted to `pod-security.admission.config.k8s.io/v1`. and move
to the extra docs section, before the KEP link. Unless I'm wrong, you can disable the PodSecurity admission plugin, just like any other: |
That's correct. So tweaked. |
🏎️ |
(to be clear, the feature gate is GA and locked, so setting |
Signed-off-by: wangyysde net_use@bzhy.com
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Promotes PodSecurity to GA
Which issue(s) this PR fixes:
Fixes #110437
xref kubernetes/enhancements#2579
/sig auth
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: