New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set ProbeTerminationGracePeriod default to true #108541
feat: set ProbeTerminationGracePeriod default to true #108541
Conversation
Skipping CI for Draft Pull Request. |
/retest |
/retest |
ac90077
to
82a4e27
Compare
/retest |
We didn't target this KEP for 1.24 and we're well past the node soft freeze. I don't want to catch anyone by surprise in defaulting this on now. Should we wait for 1.25? /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/triage accepted
/priority important-soon
for 1.25
Will quickly update KEP metadata for 1.25 so this can be included. Leaving hold on until then.
Good catch, thanks. |
/retest |
Thanks! |
/retest |
since kubernetes/enhancements#3282 merged can you add the LGTM again @dchen1107 |
@psschwei ptal |
Question: in the updated test plan for this KEP, we said we would add some unit and integration buckets. Do those need to be added before we flip the gate? (for reference, #110733 adds the units, and I plan to get the integration ones in next week) |
cc @dchen1107 since we're close to the code freeze. |
/lgtm E2E coverage for this exists iirc (please confirm) so I don't have much in the way of test qualms with this progressing. Lgtm with hold to let the unit coverage land first. |
Marked this for 1.25 milestone explicitly, but please point us to the e2e tests. Thanks! |
links to e2e tests:
|
The unit tests PR has landed #110733. We can let this go in. |
/hold cancel |
Signed-off-by: kerthcet kerthcet@gmail.com
What type of PR is this?
/kind feature
/sig node
What this PR does / why we need it:
As mentioned on https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2238-liveness-probe-grace-period#beta-122
Which issue(s) this PR fixes:
Part of kubernetes/enhancements#2238
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: