New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promoting WindowsHostProcessContainers to stable #113476
Conversation
c152757
to
3e87261
Compare
3e87261
to
e25c24a
Compare
/assign @jsturtevant @liggitt |
/approve |
@@ -21304,9 +21223,7 @@ func TestValidateWindowsHostProcessPod(t *testing.T) { | |||
|
|||
for _, testCase := range testCases { | |||
t.Run(testCase.name, func(t *testing.T) { | |||
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.WindowsHostProcessContainers, testCase.featureEnabled)() | |||
|
|||
opts := PodValidationOptions{AllowWindowsHostProcessField: testCase.featureEnabled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're dropping testing of this validation option (because the associated feature is always on now), drop the AllowWindowsHostProcessField
field from the PodValidationOptions
type and all code that checks Enabled(features.WindowsHostProcessContainers)
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - I'll make these updates today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liggitt I made the requested updates - PTAL and thanks!
e25c24a
to
404696c
Compare
404696c
to
d091326
Compare
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
d091326
to
498d065
Compare
/triage accepted |
/lgtm /retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mark Rossetti marosset@microsoft.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR sets the
WindowsHostProcessContainers
feature to stableWhich issue(s) this PR fixes:
Part of kubernetes/enhancements#1981
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig windows