e2e: remove JSON progress output on stdout #113212
Conversation
The original intention was to address "frustration of end users running the e2e suite is that they take a significant amount of time and it is difficult to gauge progress". But Ginkgo's output is different now than it was in Kubernetes 1.19. If users want to see progress, then "ginkgo --progress" might provide enough information. Printing to os.Stdout doesn't work as intended anyway when output redirection is enabled (the default for parallel runs) and causes these JSON snippets to appear as "show stdout" for each failed test in a Prow job, which is distracting.
k8s-ci-robot
added
release-note
|
@pohly: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
| @@ -62,19 +62,19 @@ func NewProgressReporter(progressReportURL string) *ProgressReporter { | |||
| return rep | |||
| } | |||
|
|
|||
| // SendUpdates serializes the current progress and prints it to stdout and also posts it to the configured endpoint if set. | |||
| // SendUpdates serializes the current progress and posts it to the configured endpoint if set. | |||
| // It does not print to stdout because that interferes with progress reporting by Ginko | |||
There was a problem hiding this comment.
s/Ginko/Ginkgo :) Let's find a chance to clean this up in the future.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The original intention was to address "frustration of end users running the e2e suite is that they take a significant amount of time and it is difficult to gauge progress". But Ginkgo's output is different now than it was in Kubernetes 1.19. If users want to see progress, then "ginkgo --progress" might provide enough information.
Which issue(s) this PR fixes:
Printing to os.Stdout doesn't work as intended when output redirection is enabled (the default for parallel runs) and causes these JSON snippets to appear as "show stdout" for each failed test in a Prow job, which is distracting.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/cc @chendave @aojea