Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate sub-microsecond eventTime changes on update #112183

Merged
merged 1 commit into from Sep 1, 2022
Merged

Tolerate sub-microsecond eventTime changes on update #112183

merged 1 commit into from Sep 1, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 1, 2022

What type of PR is this?

/kind bug
/kind api-change

What this PR does / why we need it:

Relaxes Event update validation to tolerate sub-microsecond changes in eventTime.

Part 1 of resolving #111928 (part 2 is fixing serialization/deserialization in #111936)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes spurious `field is immutable` errors validating updates to Event API objects via the `events.k8s.io/v1` API

/cc @lavalamp @dgrisonnet

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 1, 2022
@k8s-ci-robot
Copy link
Contributor

@liggitt: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 1, 2022
@liggitt liggitt mentioned this pull request Sep 1, 2022
Merged
@liggitt
Copy link
Member Author

liggitt commented Sep 1, 2022

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 1, 2022
@liggitt liggitt added this to Assigned in API Reviews Sep 1, 2022
@liggitt
Copy link
Member Author

liggitt commented Sep 1, 2022

/retest

@deads2k
Copy link
Contributor

deads2k commented Sep 1, 2022

/lgtm

We need to get this cherrypicked to at least one release prior to where we backport #111928 correct?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2022
@liggitt liggitt force-pushed the events-immutable-time-validation branch from 0df42e7 to 42bb7bb Compare September 1, 2022 19:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2022
@liggitt
Copy link
Member Author

liggitt commented Sep 1, 2022 •
edited

We need to get this cherrypicked to at least one release prior to where we backport #111928 correct?

Yeah... I'd probably take this back to 1.22+ for the September patch releases, and take #111928 back to 1.23+ in the October patch releases

@lavalamp
Copy link
Member

lavalamp commented Sep 1, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Sep 1, 2022
Merged
Merged
Merged
Merged
@liggitt
Copy link
Member Author

liggitt commented Sep 1, 2022

Thanks, opened picks to 1.22-1.25

@k8s-ci-robot k8s-ci-robot merged commit 475e6d6 into kubernetes:master Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 1, 2022
k8s-ci-robot added a commit that referenced this pull request Sep 2, 2022
@k8s-ci-robot
Merge pull request #112188 from liggitt/automated-cherry-pick-of-#112…
fd97655 
…183-upstream-release-1.23

Automated cherry pick of #112183: Tolerate sub-microsecond eventTime changes on update
k8s-ci-robot added a commit that referenced this pull request Sep 2, 2022
@k8s-ci-robot
Merge pull request #112189 from liggitt/automated-cherry-pick-of-#112…
b89409c 
…183-upstream-release-1.22

Automated cherry pick of #112183: Tolerate sub-microsecond eventTime changes on update
k8s-ci-robot added a commit that referenced this pull request Sep 2, 2022
@k8s-ci-robot
Merge pull request #112186 from liggitt/automated-cherry-pick-of-#112…
fae7789 
…183-upstream-release-1.25

Automated cherry pick of #112183: Tolerate sub-microsecond eventTime changes on update
k8s-ci-robot added a commit that referenced this pull request Sep 2, 2022
@k8s-ci-robot
Merge pull request #112187 from liggitt/automated-cherry-pick-of-#112…
4167306 
…183-upstream-release-1.24

Automated cherry pick of #112183: Tolerate sub-microsecond eventTime changes on update
@liggitt liggitt moved this from Assigned to API review completed, 1.26 in API Reviews Sep 2, 2022
@liggitt liggitt deleted the events-immutable-time-validation branch November 26, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@lavalamp lavalamp

@deads2k deads2k

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.26
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @deads2k @lavalamp