New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FilterLatency tracing for APIServerTracing #113217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/assign @smarterclayton |
/kind feature |
/priority important-soon |
7885335
to
fee3832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
fee3832
to
b97eb7e
Compare
/triage accepted |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
b97eb7e
to
ed1610a
Compare
Had to fix a test after the rebase |
/lgtm thanks @dashpole |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, dims, logicalhan, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/sig instrumentation
/priority important-soon
What this PR does / why we need it:
Part of #113170, which is a beta requirement for the API Server tracing KEP: kubernetes/enhancements#647
This was requested here: kubernetes/enhancements#647 (comment) to measure "request filter processing -- for filters like authorization, priority and fairness and other, how much time we spent in each".
Special notes for your reviewer:
Rather than explicitly keep a reference to the current span in the
requestFilterRecord
struct, we store and retrieve it from the current context. This minimizes the amount of tracking we have to do.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: