Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kube-scheduler: Deprecate Component config v1beta3 #112257

Merged
merged 2 commits into from Sep 7, 2022
Merged

Kube-scheduler: Deprecate Component config v1beta3 #112257

merged 2 commits into from Sep 7, 2022

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Sep 6, 2022 •
edited

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind cleanup
/sig scheduling

What this PR does / why we need it:

In #112038, we're ready to remove CC v1beta2, but following https://kubernetes.io/docs/reference/using-api/deprecation-policy/#component-config-structures deprecation policy, we should remove it until 9 months or 3 releases (whichever is longer).

Besides, also mark v1beta3 as deprecated.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kube scheduler Component Config release version v1beta3 is deprecated in v1.26 and will be removed in v1.29, 
also v1beta2 will be removed in v1.28.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@kerthcet
Modify release version of removing scheduler CC v1beta2
532d1df 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 6, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Sep 6, 2022

/assign @ahg-g

@kerthcet
Copy link
Member Author

kerthcet commented Sep 6, 2022

/retest

@kerthcet
Add deprecation warning of removing scheduler CC v1beta3
700065a 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 7, 2022
@kerthcet kerthcet changed the title Modify release version of removing scheduler CC v1beta2 Kube-scheduler: Deprecate Component config v1beta3 Sep 7, 2022
This was referenced Sep 7, 2022
Merged
Closed
SataQiu
SataQiu approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@ahg-g
Copy link
Member

ahg-g commented Sep 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kerthcet, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3d3820b into kubernetes:master Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 7, 2022
@kerthcet kerthcet deleted the cleanup/modify-remove-release branch September 7, 2022 07:05
@alculquicondor alculquicondor mentioned this pull request Nov 4, 2022
Merged
@sanposhiho sanposhiho mentioned this pull request Apr 25, 2023
Merged
@mzaian mzaian mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu approved these changes

@chendave chendave Awaiting requested review from chendave

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@SataQiu SataQiu

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kerthcet @k8s-ci-robot @ahg-g @SataQiu