Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Enables a few Conformance tests for Windows (part 2) #108592

Merged
merged 1 commit into from Jul 29, 2022
Merged

tests: Enables a few Conformance tests for Windows (part 2) #108592

merged 1 commit into from Jul 29, 2022

Conversation

claudiubelu
Copy link
Contributor

What type of PR is this?

/sig testing
/sig windows

/kind feature
/priority important-soon
/milestone v1.24

What this PR does / why we need it:

Some of these tests could not be run previously, especially on Windows Docker containers. But now, by using Windows Containerd, we can finally run them:

  • /etc/hosts related tests: These were not supported because it required single file mappings, which is possible in Containerd.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 8, 2022
@claudiubelu claudiubelu mentioned this pull request Mar 8, 2022
Closed
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-containerd

@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 8, 2022
@marosset marosset added this to In Progress (v1.24) in SIG-Windows Mar 10, 2022
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 14, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Mar 16, 2022
@SergeyKanzhelev
Copy link
Member

/assign

@ehashman
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 17, 2022
@claudiubelu
Copy link
Contributor Author

/close

SIG-Windows automation moved this from In Progress (v1.24) to Done (v1.23) Mar 22, 2022
SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Mar 22, 2022
oomichi
oomichi reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most part seems good for me, just one comment.

/cc @oomichi

test/e2e/common/node/kubelet.go Show resolved Hide resolved
@jsturtevant
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-containerd

@claudiubelu
tests: Enables a few Conformance tests for Windows
0570f61 
Some of these tests could not be run previously, especially on Windows
Docker containers. But now, by using Windows Containerd, we can finally
run them:

- HostNetwork=true tests: This can now be enabled on Windows Privileged Containers.
- /etc/hosts related tests: These were not supported because it required single
  file mappings, which is possible in Containerd.
- termination message as non-root user: Requires RunAsUsername, and single file
  mappings.
@oomichi
Copy link
Member

oomichi commented May 6, 2022

/test pull-kubernetes-integration

@jsturtevant
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-containerd

1 similar comment
@jsturtevant
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-containerd

oomichi
oomichi reviewed May 16, 2022
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating.

/approve

@claudiubelu
Copy link
Contributor Author

/assign @johnbelamaric

@claudiubelu
Copy link
Contributor Author

/assign @smarterclayton

@harshitasao
Copy link

Hi @claudiubelu, k8s 1.25 Bug Triage Shadow here, just checking in to see if this is still on track for k8s 1.25?
Thank you.

@claudiubelu
Copy link
Contributor Author

Hi @claudiubelu, k8s 1.25 Bug Triage Shadow here, just checking in to see if this is still on track for k8s 1.25? Thank you.

Yes it is. Waiting for reviews / for it to get merged.

@claudiubelu
Copy link
Contributor Author

/assign @smarterclayton

@marosset
Copy link
Contributor

/lgtm
Thanks for this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2022
@harshitasao
Copy link

Hello @claudiubelu, with the code freeze approaching, is this still on track for v1.25?
Thanks!

@claudiubelu
Copy link
Contributor Author

Hello @claudiubelu, with the code freeze approaching, is this still on track for v1.25? Thanks!

Yes, this enables a Conformance test for Windows, which passes on Windows, as it can be seen in the pull-kubernetes-e2e-capz-windows-containerd job.

@marosset
Copy link
Contributor

@smarterclayton @johnbelamaric @dims - Can we try and get this into v1.25 release?

@dims
Copy link
Member

dims commented Jul 29, 2022

looks like we are still ok to land this ("updates to conformance tests for additional scenarios are only allowed before code freeze dates set by the release team to allow enough soak time of the changes" from https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md#promoting-tests-to-conformance)

also since this is an update to an existing test and we are before the code freeze deadline we should be good to land this.

@claudiubelu please watch the tests that this touched for 2 weeks on both windows and linux platforms for flakes. If we see stuff we have to revert it and try again for 1.26. sounds good?

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, dims, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4f469e6 into kubernetes:master Jul 29, 2022
SIG-Windows automation moved this from Done (v1.23) to Done (v1.25) Jul 29, 2022
SIG Node CI/Test Board automation moved this from Issues - In progress to Done Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@smarterclayton smarterclayton

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Triage
SIG-Windows
  
Done (v1.25)
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet