GIT-110239: fix activeDeadlineSeconds enforcement bug #110294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/apps
harshanarayana
force-pushed
the
bug/git-110239/fix-activedeadline-enforcement
branch
from
2bf662c
to
4c125cc
Compare
|
/test all |
|
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
FillZpp
reviewed
May 31, 2022
harshanarayana
force-pushed
the
bug/git-110239/fix-activedeadline-enforcement
branch
3 times, most recently
from
33f930a
to
c132ccf
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @alculquicondor |
aojea
reviewed
May 31, 2022
harshanarayana
force-pushed
the
bug/git-110239/fix-activedeadline-enforcement
branch
from
c132ccf
to
caf33cf
Compare
k8s-ci-robot
removed
the
size/S
|
/release-note-edit |
|
I don't know if that worked. Could you update the issue description with the suggested release note? |
k8s-ci-robot
added
release-note
|
@alculquicondor Done. PTAL. Updated the other PRs with the same |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
FYI, the test is flaky #110697 |
|
@alculquicondor taking a look now. |
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 7, 2022
…of-#110294-upstream-release-1.22-1655134642 Cherry pick of #110294 GIT-110239: fix activeDeadlineSeconds enforcement bug
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 7, 2022
…of-#110294-upstream-release-1.24-1655134646 Cherry pick of #110294 GIT-110239: fix activeDeadlineSeconds enforcement bug
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 7, 2022
…of-#110294-upstream-release-1.23-1655134684 Cherry pick of #110294 GIT-110239: fix activeDeadlineSeconds enforcement bug
9 tasks
9 tasks
|
/remove-sig scheduling |
k8s-ci-robot
removed
the
sig/scheduling
mimowo
added a commit
to mimowo/kubernetes
that referenced
this pull request
Oct 20, 2022
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
Merged
7 tasks
ivelichkovich
pushed a commit
to ivelichkovich/kubernetes
that referenced
this pull request
Dec 20, 2022
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
jaehnri
pushed a commit
to jaehnri/kubernetes
that referenced
this pull request
Jan 3, 2023
…gration/job I think I'm ready to start review and LGTM code changes within this package, but not necessarily for the entire sig-apps. My PRs to the packages: kubernetes#110292 kubernetes#111113 kubernetes#112948 PRs to the packages I contributed reviews to: kubernetes#113166 kubernetes#110294
chenchun
pushed a commit
to chenchun/kubernetes
that referenced
this pull request
Mar 20, 2024
chenchun
pushed a commit
to chenchun/kubernetes
that referenced
this pull request
Mar 20, 2024
…equest !670) Cherry pick of kubernetes#110294: fix activeDeadlineSeconds enforcement bug kubernetes#110543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
The current implementation of the
job_controller.gofails to enforce theactiveDeadlineSecondsconfiguration properly when theJobReadyPodsfeature gate is enabled.This causes the pods taking longer than
activeDeadlineSecondsto not get deleted on time. When the pods actually do get terminated, it will then track this and mark this asDeadlineExceededcondition. This is not the documented behaviour ofactiveDeadlineSeconds. This PR addresses the changes required to fix the same.Which issue(s) this PR fixes:
Fixes #110239
Special notes for your reviewer:
Implementation is based on the suggestion from @alculquicondor in #110239 (comment)
This changes also modifies one of the existing test to make sure the re-queue behaviour is asserted to prevent future regressions.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: