Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zone field to vsphere test cloudconfig #112427

Merged
merged 1 commit into from Sep 14, 2022
Merged

Add zone field to vsphere test cloudconfig #112427

merged 1 commit into from Sep 14, 2022

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Sep 13, 2022 •
edited

This allows same configuration of cloudprovider and test.

Helps with e2e of vsphere intree driver

Allow Label section in vsphere e2e cloudprovider configuration

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 13, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 13, 2022
@gnufied
Copy link
Member Author

gnufied commented Sep 14, 2022

/retest
/assign @xing-yang @jsafrane

@xing-yang
Copy link
Contributor

/assign @divyenpatel

@jsafrane
Copy link
Member

Please add a release note.
lgtm otherwise, I let @divyenpatel to take a look - we'd lilke e2e test to at least parse cloud provider cofig with [labels] section.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 14, 2022
@gnufied
Copy link
Member Author

gnufied commented Sep 14, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 14, 2022
@divyenpatel
Copy link
Member

e2e in-tree test does not use this label? How does this e2e test config help?

@gnufied
Copy link
Member Author

gnufied commented Sep 14, 2022

It is unfortunate that there is a difference between cloudconfig used by e2e vs actual cloudprovider. Ideally, they should have been the same because it is much easier to extract cloud-config and run tests with same configuration. So that is what this PR is trying to fix.

It does not matter if tests use label field, but the tests should still be able to parse and run even if label field was there in actual cloudconfig.

divyenpatel
divyenpatel approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 148476e into kubernetes:master Sep 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 14, 2022
This was referenced Sep 15, 2022
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 15, 2022
Closed
@cpanato
Copy link
Member

cpanato commented Sep 19, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 19, 2022
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2022
@k8s-ci-robot
Merge pull request #112478 from gnufied/automated-cherry-pick-of-#112…
39b0a89 
…427-upstream-release-1.25

Automated cherry pick of #112427: Add zone field to vsphere test cloudconfig
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2022
@k8s-ci-robot
Merge pull request #112479 from gnufied/automated-cherry-pick-of-#112…
4de07c2 
…427-upstream-release-1.24

Automated cherry pick of #112427: Add zone field to vsphere test cloudconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyenpatel divyenpatel divyenpatel approved these changes

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@divyenpatel divyenpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gnufied @xing-yang @jsafrane @divyenpatel @k8s-ci-robot @cpanato