New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate limiting when calling STS assume role API #110706
Add rate limiting when calling STS assume role API #110706
Conversation
Hi @prateekgogia. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @nckturner @wongma7 |
/ok-to-test |
/area provider-aws |
@nckturner: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area provider/aws |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a test that shows what happens when trying to assume a different IAM role within 1 second of a previous successful attempt. That feels like the most important test to have, to be honest.
/remove-kind bug
Lack of cache is not a bug.
See my suggestion above and let me know what you think. |
Also, I'm going to re-label it as a bug, as this is causing issues for EKS users. /kind bug |
Updated the description to include the change. PTAL. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, prateekgogia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
@prateekgogia: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
…-#110706-upstream-release-1.23 Automated cherry pick of #110706: Add rate limiting when calling STS assume role API
…-#110706-upstream-release-1.24 Automated cherry pick of #110706: Add rate limiting when calling STS assume role API
Cherry pick from k/k PR kubernetes#110706 v1.20-1.23 See merge request eks-dataplane/eks-kubernetes-patches!23
Fix kubernetes#110706 patch naming See merge request eks-dataplane/eks-kubernetes-patches!29
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds rate limiting for Assume role call when failing to assume an IAM role in CCM. It caches the assume role API call result for 1 second and blocks all call till the cache is valid.
The below screenshot shows the result of this change, reduction in assumeRole API calls after this change was applied at 05:10.
Which issue(s) this PR fixes:
Fixes #
kubernetes/cloud-provider-aws#284
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: