New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append new pod conditions when deleting pods to indicate the reason for pod deletion #110959
Append new pod conditions when deleting pods to indicate the reason for pod deletion #110959
Conversation
Hi @mimowo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc |
1bd702d
to
ea8da83
Compare
3d37248
to
55654ec
Compare
5579cc0
to
49f995c
Compare
/retest |
51327eb
to
00d23f7
Compare
00d23f7
to
63cd724
Compare
lgtm |
…on` field indicates the reason: - PreemptionByKubeScheduler (Pod preempted by kube-scheduler) - DeletionByTaintManager (Pod deleted by taint manager due to NoExecute taint) - EvictionByEvictionAPI (Pod evicted by Eviction API) - DeletionByPodGC (an orphaned Pod deleted by PodGC)PreemptedByScheduler (Pod preempted by kube-scheduler)
63cd724
to
04fcbd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
since Antonio gave his 👍 above
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, liggitt, mimowo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority important-soon |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR appends pod conditions with a dedicated pod condition type
DisruptionTarget
.Its
reason
field indicates the reason for pod termination:Which issue(s) this PR fixes:
Special notes for your reviewer:
DisruptionTarget
condition: Add worker to clean up stale DisruptionTarget condition #111475Update KEP-3329 "Retriable and non-retriable Pod failures for Jobs" enhancements#3438.
Does this PR introduce a user-facing change?
Yes, it appends new pod conditions when deleting a pod.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: