Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing NodeIPAM to support multiple ClusterCIDRs #2593

Closed
2 of 8 tasks
rahulkjoshi opened this issue Apr 1, 2021 · 71 comments
Closed
2 of 8 tasks

Enhancing NodeIPAM to support multiple ClusterCIDRs #2593

rahulkjoshi opened this issue Apr 1, 2021 · 71 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@rahulkjoshi
Copy link
Contributor

rahulkjoshi commented Apr 1, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

This KEP has been withdrawn #4253 , there is some remaining work on creating a new repo to host the existing code and removing it from tree

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 1, 2021
@rahulkjoshi
Copy link
Contributor Author

/sig network

@dcbw
Copy link
Member

dcbw commented Jun 10, 2021

[sig-network 2021-06-10] Waiting for SIG Network to decide whether to do this as a built-in or a CRD. Tim wants to see if we can define the type here as a CRD and make the controller built-in first. If we can't figure this out in the next few weeks, we'll just try to make it a built-in.

@wojtek-t
Copy link
Member

wojtek-t commented Sep 6, 2021

@rahulkjoshi - to target 1.23, you need PRR approved By Thursday - feel free to assign to me once you open a PR

@salaxander
Copy link

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 7, 2021
@salaxander
Copy link

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 7, 2021
@salaxander salaxander added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 7, 2021
@salaxander
Copy link

Hi @rahulkjoshi! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09. Here's where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

I see there's an open PR that will complete those last 2 items, so once that merges we're all good to go!

Thanks!

@supriya-premkumar
Copy link
Contributor

Hi @rahulkjoshi, 1.23 Enhancements Shadow here 👋🏽
This issue is currently marked as atRisk and I am following up as we are approaching the enhancements freeze deadline at 23:59:59 PDT on Thursday, September 9th.

Looks like the merged KEP number doesn't match the enhancements issue #2593. It is currently pointing to the PR #. Could you please update that?

@rahulkjoshi
Copy link
Contributor Author

@supriya-premkumar @salaxander please take a look and let me know if this PR needs any other changes.

@supriya-premkumar
Copy link
Contributor

Thank you @rahulkjoshi. Looks like this enhancement is all set for the freeze party 🎉
I will update the tracking sheet.

@supriya-premkumar
Copy link
Contributor

Hi @rahulkjoshi👋🏽 1.23 Enhancements Shadow here
Just checking on the PR status for this issue as we are approaching code freeze deadline on Tuesday, November 16 at 6:00 pm PST

I see that the linked PRs are merged. Are there any other associated PRs for this issue?
Also, please update the respective PRs in the description

Marking this issue as tracked. Please let me know if there are any open PRs.

@rahulkjoshi
Copy link
Contributor Author

rahulkjoshi commented Nov 10, 2021

I think the code will not be merged before the 1.23 deadline. We'll probably merge into 1.24

@sarveshr7

@supriya-premkumar
Copy link
Contributor

supriya-premkumar commented Nov 17, 2021

@rahulkjoshi Are there any open PRs? If yes, Could you please link them in the description?
Marking this issue as atRisk for now

@rahulkjoshi
Copy link
Contributor Author

To my knowledge, there aren't any open PRs. I'll switch this to be targeting alpha for 1.24 since it seems we're missing the deadline.

@reylejano
Copy link
Member

Thank you @rahulkjoshi for confirming that this enhancement will target 1.24
/milestone v1.24

@k8s-ci-robot k8s-ci-robot removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 15, 2023
@thockin thockin added this to the v1.28 milestone Mar 16, 2023
@thockin thockin mentioned this issue Apr 27, 2023
4 tasks
@thockin
Copy link
Member

thockin commented Apr 27, 2023

Milestoning for 1.28, but @aojea is driving a discussion about overlap with #1880

@Atharva-Shinde Atharva-Shinde removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@thockin thockin modified the milestones: v1.28, v1.29 Jun 7, 2023
@uablrek
Copy link

uablrek commented Jul 10, 2023

The perNodeHostBits should be per family.

To have just one for both ipv4/ipv6 enforces a limit on the number of PODs on a node only based on the shortcomings of ipv4. It should be possible to define for instance "perNodeHostBits4: 7" and "perNodeHostBits6: 32"

Some CNI-plugins, like Calico, already allows to configure ipv4 to some (not all) PODs on a node. My own kube-ipam can assign ipv4 addresses only to selected namespaces. I expect this feature, in some form, to be common practice in large cluster in the future.

It is possible to assign large segments to ipv6-only nodes in a cluster, and have a mix of dual-stack and ipv6-only nodes with the current implementation, but that is not enough.

@thockin
Copy link
Member

thockin commented Jul 14, 2023 via email

@thockin
Copy link
Member

thockin commented Sep 27, 2023

Are we still shooting for Beta in 29?

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 27, 2023
@aojea
Copy link
Member

aojea commented Sep 27, 2023

Are we still shooting for Beta in 29?

There is concerns about moving this API inside the core group as it can cause confusion on users and the networking implementation already have their own mechanisms , see #4174

@rayandas
Copy link
Member

Hello @rahulkjoshi 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29.
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Update the latest-milestone and graduation criteria (if any).

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@BenTheElder
Copy link
Member

I believe this should be removed from the milestone following #4253?

@thockin thockin removed this from the v1.29 milestone Sep 29, 2023
@thockin
Copy link
Member

thockin commented Sep 29, 2023 via email

@aojea aojea removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status lead-opted-in Denotes that an issue has been opted in to a release labels Oct 4, 2023
@npolshakova npolshakova added this to the v1.29 milestone Oct 4, 2023
@aojea
Copy link
Member

aojea commented Nov 16, 2023

Are we still shooting for Beta in 29?

There is concerns about moving this API inside the core group as it can cause confusion on users and the networking implementation already have their own mechanisms , see #4174

/close

@k8s-ci-robot
Copy link
Contributor

@aojea: Closing this issue.

In response to this:

Are we still shooting for Beta in 29?

There is concerns about moving this API inside the core group as it can cause confusion on users and the networking implementation already have their own mechanisms , see #4174

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented Jan 18, 2024

This is now implemented out of tree https://github.com/kubernetes-sigs/node-ipam-controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
Status: Graduating
Status: Removed From Milestone
Status: Removed from Milestone
Obsolete: SIG-Network KEPs (see https...
DONE (GA, merged, gate removed)
Development

No branches or pull requests